Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/708#discussion_r12463230
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
    @@ -250,7 +250,7 @@ class BlockManagerMasterActor(val isLocal: Boolean, 
conf: SparkConf, listenerBus
               // Remove the block from the slave's BlockManager.
               // Doesn't actually wait for a confirmation and the message 
might get lost.
               // If message loss becomes frequent, we should add retry logic 
here.
    -          blockManager.get.slaveActor ! RemoveBlock(blockId)
    +          
blockManager.get.slaveActor.ask(RemoveBlock(blockId))(akkaTimeout)
    --- End diff --
    
    What does it mean if the result is `false` here? Should we print something 
to the user?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to