cloud-fan commented on a change in pull request #34554:
URL: https://github.com/apache/spark/pull/34554#discussion_r747991324
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -193,6 +195,85 @@ abstract class JdbcDialect extends Serializable with
Logging{
case _ => value
}
+ /**
+ * Turns a single Filter into a String representing a SQL expression.
+ * Returns None for an unhandled filter.
+ */
+ @Since("3.3.0")
+ def compileFilter(f: Filter): Option[String] = {
Review comment:
The problem is, is there any database that has a different
filter/aggregate syntax? The main point of having it in `JdbcDialect` is to
allow certain databases to overwrite it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
