huaxingao commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r749759059
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -598,6 +598,13 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : VERSION AS OF version=INTEGER_VALUE
+ | FOR SYSTEM_VERSION AS OF version=INTEGER_VALUE
Review comment:
Changed to `INTEGER_VALUE | IDENTIFIER` so it can take both number and
non-number.
I didn't change it to `String`. Seems to me that `String` type requires
single quotation. For example, the syntax needs to be ` SELECT * FROM
default.people10m VERSION AS OF '123456789'`. I think we want to have ` SELECT
* FROM default.people10m VERSION AS OF 123456789`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
