huaxingao commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r750055749
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -598,6 +598,13 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : VERSION AS OF version=INTEGER_VALUE
Review comment:
@rdblue I looked hive syntax and it seems this `FOR` is always required
for `SYSTEM_XXX`. Also checked SQL 2011 Standard
https://en.wikipedia.org/wiki/SQL:2011#Temporal_support, SAP HANA uses `FOR
SYSTEM_TIME AS OF` and IBM DB2 uses `FOR SYSTEM_TIME AS OF`. I removed the ?
for `FOR` and made it only apply for `SYSTEM_XXX`. Hope this is fine with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
