Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5908#discussion_r30031423
--- Diff:
core/src/main/scala/org/apache/spark/storage/ExternalBlockStore.scala ---
@@ -113,7 +143,13 @@ private[spark] class ExternalBlockStore(blockManager:
BlockManager, executorId:
}
override def getValues(blockId: BlockId): Option[Iterator[Any]] = {
- getBytes(blockId).map(buffer => blockManager.dataDeserialize(blockId,
buffer))
+ try {
+ externalBlockManager.flatMap(_.getValues(blockId))
+ } catch {
+ case NonFatal(t) =>
+ logError(s"error in getValues from $blockId", t)
--- End diff --
This is really opinion too, but if it's not fatal, I think it could be a
warning instead of error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
