Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5908#discussion_r30031387
--- Diff:
core/src/main/scala/org/apache/spark/storage/TachyonBlockManager.scala ---
@@ -120,6 +134,16 @@ private[spark] class TachyonBlockManager() extends
ExternalBlockManager with Log
}
}
+ override def getValues(blockId: BlockId): Option[Iterator[_]] = {
+ val file = getFile(blockId)
+ if (file == null || file.getLocationHosts().size() == 0) {
+ return None
+ }
+ val is = file.getInStream(ReadType.CACHE)
+ assert (is != null)
--- End diff --
I think the code is pretty inconsistent about this, but do you mean
`assert` here? if assertions aren't on is it OK if this isn't checked?
probably, just asking. Also tiny nit: you don't need `return` below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
