zero323 commented on a change in pull request #34466:
URL: https://github.com/apache/spark/pull/34466#discussion_r753785413
##########
File path: python/pyspark/accumulators.py
##########
@@ -46,7 +48,10 @@ def _deserialize_accumulator(aid, zero_value, accum_param):
return accum
-class Accumulator(object):
+T = TypeVar("T")
Review comment:
Let's not touch things which are not strictly related to this particular
PR. Not to mention we should never have annotations in both `py` and `pyi`
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
