zero323 commented on a change in pull request #34466:
URL: https://github.com/apache/spark/pull/34466#discussion_r753820635
##########
File path: python/pyspark/context.py
##########
@@ -221,7 +246,7 @@ def _do_init(
if environment:
for key, value in environment.items():
self._conf.setExecutorEnv(key, value)
- for key, value in DEFAULT_CONFIGS.items():
+ for key, value in DEFAULT_CONFIGS.items(): # type: ignore[assignment]
Review comment:
Instead of ignoring here, we can add
```str
DEFAULT_CONFIGS: Dict[str, Any] = {
```
and, for consistency, adjust `environment` in `__init__` and `_do__init` as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
