nchammas commented on a change in pull request #34671:
URL: https://github.com/apache/spark/pull/34671#discussion_r754642606
##########
File path: python/pyspark/ml/common.py
##########
@@ -15,11 +15,15 @@
# limitations under the License.
#
+from typing import Any, Callable
+from pyspark.ml._typing import C, JavaObjectOrPickleDump
Review comment:
Ah OK. The `TYPE_CHECKING` block addresses the namespace pollution
issue, I suppose.
But can you elaborate on why the type needs to be quoted? I understand
that's for when the type is not known at that point in time (e.g. a
self-referential type), but that isn't the case here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
