zero323 commented on a change in pull request #34671:
URL: https://github.com/apache/spark/pull/34671#discussion_r754647909
##########
File path: python/pyspark/ml/common.py
##########
@@ -15,11 +15,15 @@
# limitations under the License.
#
+from typing import Any, Callable
+from pyspark.ml._typing import C, JavaObjectOrPickleDump
Review comment:
In general, whatever goes into `TYPE_CHECKING` is not imported during
normal execution. So as is, all the names we use would be undefined when these
scripts are imported.
[PEP 563](https://www.python.org/dev/peps/pep-0563/) introduces a concept of
postponed evaluation, but were not ready to go there yet (for starters, we
still didn't formally drop 3.6 support ‒ I am working on cleaning the code,
then we have some components that might require code changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
