Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5835#issuecomment-101000644
The changes look fine. I don't have a strong preference for this, but I
would slightly prefer to merge this into master branch only (for 1.5 release)
instead of into both master and 1.4 branches. This is a very subtle change in
behavior: basically now we do reflection in places where we didn't use to, and
we skip doing reflection in places where we used to do so.
I agree that the changes here are strictly more correct, but the worst case
of not including this in the 1.4 release is that we maintain the "broken"
behavior that has worked for most users so far, which is much safer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
