Github user preeze commented on a diff in the pull request:
https://github.com/apache/spark/pull/5835#discussion_r30069632
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -274,7 +265,7 @@ private[spark] object ClosureCleaner extends Logging {
// required fields from the original object. We need the parent here
because the Java
// language specification requires the first constructor parameter
of any closure to be
// its enclosing object.
- val clone = instantiateClass(cls, parent, inInterpreter)
+ val clone = instantiateClass(cls, parent, Utils.isInInterpreter)
--- End diff --
Very valid point. I overlooked this being more focused on clarifying the
confusion around exception handling and negation. Will fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
