cloud-fan commented on a change in pull request #34060:
URL: https://github.com/apache/spark/pull/34060#discussion_r756896465
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateTableExec.scala
##########
@@ -32,10 +33,16 @@ case class CreateTableExec(
identifier: Identifier,
tableSchema: StructType,
partitioning: Seq[Transform],
- tableProperties: Map[String, String],
+ tableSpec: TableSpec,
ignoreIfExists: Boolean) extends LeafV2CommandExec {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
+ val props = CatalogV2Util.convertTableProperties(
Review comment:
let's not expose this as it's intermediate
```
val tableProperties = {
val props = ...
CatalogV2Util.withDefaultOwnership(props)
}
```
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateTableExec.scala
##########
@@ -32,10 +33,16 @@ case class CreateTableExec(
identifier: Identifier,
tableSchema: StructType,
partitioning: Seq[Transform],
- tableProperties: Map[String, String],
+ tableSpec: TableSpec,
ignoreIfExists: Boolean) extends LeafV2CommandExec {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
+ val props = CatalogV2Util.convertTableProperties(
Review comment:
let's not expose this as it's intermediate. how about
```
val tableProperties = {
val props = ...
CatalogV2Util.withDefaultOwnership(props)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
