cloud-fan commented on a change in pull request #34060:
URL: https://github.com/apache/spark/pull/34060#discussion_r756898209
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -481,19 +481,26 @@ class PlanResolutionSuite extends AnalysisTest {
"other" -> "20")
parseAndResolve(sql) match {
- case create: CreateV2Table =>
- assert(create.catalog.name == "testcat")
- assert(create.tableName == Identifier.of(Array("mydb"), "table_name"))
+ case create: CatalystCreateTable =>
+ assert(create.name.asInstanceOf[ResolvedDBObjectName].catalog.name ==
"testcat")
+
assert(create.name.asInstanceOf[ResolvedDBObjectName].nameParts.mkString(".") ==
+ "mydb.table_name")
assert(create.tableSchema == new StructType()
.add("id", LongType)
.add("description", StringType)
.add("point", new StructType().add("x", DoubleType).add("y",
DoubleType)))
assert(create.partitioning.isEmpty)
- assert(create.properties == expectedProperties)
Review comment:
I think we don't need to test it now as it's not part of the resolution
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
