c21 commented on a change in pull request #34702:
URL: https://github.com/apache/spark/pull/34702#discussion_r757151713
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -423,6 +423,9 @@ object QueryExecution {
PlanSubqueries(sparkSession),
RemoveRedundantProjects,
EnsureRequirements(),
+ // `ReplaceHashWithSortAgg` needs to be added after `EnsureRequirements`
to guarantee the
Review comment:
Yes it is. If we change our planning to bottom-up and propagate each
node output ordering info during planning, then we can run this rule during
planning. For now, we have to add it after `EnsureRequirements`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
