sathiyapk commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r757960252
##########
File path:
sql/core/src/test/resources/sql-tests/results/postgreSQL/float8.sql.out
##########
@@ -319,37 +319,37 @@ struct<five:string,f1:double,round_f1:double>
-- !query
select ceil(f1) as ceil_f1 from float8_tbl f
-- !query schema
-struct<ceil_f1:bigint>
+struct<ceil_f1:double>
-- !query output
--34
-0
-1
-1005
-9223372036854775807
+-34.0
+0.0
+1.0
+1.2345678901234E200
+1005.0
Review comment:
In order to avoid any breaking changes, shall we cast the output type of
`ceil`/`floor` to Long if the scale is 0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
