sathiyapk commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r758509703
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -243,40 +243,26 @@ case class Cbrt(child: Expression) extends
UnaryMathExpression(math.cbrt, "CBRT"
examples = """
Examples:
> SELECT _FUNC_(-0.1);
- 0
+ 0.0
> SELECT _FUNC_(5);
Review comment:
For an integral type with scale parameter 0, we will get an integral
type as the output. We cover this case in the unit test
`checkEvaluation(Ceil(5, 0), 5)`.
We could keep the output type to bigInt if the scale parameter is 0 for
`floor`/`ceil` but the behavior will be different than that of `round`/`bround`
but i think it should be ok. What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
