AngersZhuuuu commented on pull request #34710: URL: https://github.com/apache/spark/pull/34710#issuecomment-982229402
> The function submitApplication returns the appId and now that isn't used in this case which seems a bit odd. All we did here was move the assignment to be a little bit sooner and there is no explanation as to why and nothing here keeping someone from changing it back accidentally. For client mode, it directly call `submitApplication` and return appId to `YarnClientSchedulerBackend.buildtoYarn()`. So for client mode, we only can assign ApplicationId to `appId` in `submitApplication`. Then since this value is assigned. so We don't need to add a new variable `appId ` in `createContainerLaunchContext`. and don need assign `this.appId` in `run()`. The intention of this PR is not to assign values in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
