AngersZhuuuu commented on pull request #34710: URL: https://github.com/apache/spark/pull/34710#issuecomment-982717141
> The above doesn't answer my main question as to why this change is needed? what is broken that needs this change? The description mentions: > > > In client mode, user can use this value to get the application id. > > How is the user getting the application Id from a spark private variable? Some internal code, we add some plugin code in internal code and need this value. > I assume you mean `YarnClientSchedulerBackend.bindToYarn()`. yes we return appId to this and it uses it, and I can see where this perhaps cleans up the code by setting this.appId directly, but it only changes it very slightly to set it a bit earlier. From just a brief look I don't see why it needs to be set earlier, so a description as to why is needed. I thinks it's also a code refactor so I raise this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
