cloud-fan commented on a change in pull request #34754:
URL: https://github.com/apache/spark/pull/34754#discussion_r759935005
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -586,19 +586,13 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
AppendData.byName(v2Relation, df.logicalPlan, extraOptions.toMap)
case (SaveMode.Overwrite, _) =>
- ReplaceTableAsSelectStatement(
- nameParts,
- df.queryExecution.analyzed,
- partitioningAsV2,
- None,
- Map.empty,
- Some(source),
- Map.empty,
- extraOptions.get("path"),
- extraOptions.get(TableCatalog.PROP_COMMENT),
- extraOptions.toMap,
- None,
- orCreate = true) // Create the table if it doesn't exist
+ val tableSpec = TableSpec(None, Map.empty, Some(source), Map.empty,
Review comment:
let's use named parameter here: `TableSpec(bucketSpec = None, ...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
