cloud-fan commented on a change in pull request #34754:
URL: https://github.com/apache/spark/pull/34754#discussion_r759937291
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -196,11 +204,19 @@ case class AtomicReplaceTableAsSelectExec(
partitioning: Seq[Transform],
plan: LogicalPlan,
query: SparkPlan,
- properties: Map[String, String],
+ tableSpec: TableSpec,
writeOptions: CaseInsensitiveStringMap,
orCreate: Boolean,
invalidateCache: (TableCatalog, Table, Identifier) => Unit) extends
TableWriteExecHelper {
+ val properties = {
+ val props = CatalogV2Util.convertTableProperties(
Review comment:
nit: should the util function take `TableSpec` directly? and also fill
the ownership property. Then we can simplify the code here and other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
