Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5830#issuecomment-101072742
Basically all of my comments are small. In the next release, we'll have to
make metadata easier to work with.
I feel like we need to clarify the role of UnresolvedAttribute in ML, but
that could come in a later JIRA+PR. Specifically, there are places where we
treat NumericAttribute as the default, such as in AttributeGroup.fromMetadata
and AttributeGroup.toMetadataImpl, but now UnresolvedAttribute is the new
default.
Please let me know when I should make a final pass---thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
