huaxingao commented on a change in pull request #34673:
URL: https://github.com/apache/spark/pull/34673#discussion_r762662738
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala
##########
@@ -71,6 +71,14 @@ private[v2] trait V2JDBCTest extends SharedSparkSession with
DockerIntegrationFu
def testCreateTableWithProperty(tbl: String): Unit = {}
+ def indexOptions(catalogName: String): String = {
+ catalogName match {
+ case "mysql" => "KEY_BLOCK_SIZE=10"
+ case "postgresql" => "FILLFACTOR=70"
+ case _ => ""
+ }
+ }
Review comment:
I think what @cloud-fan meant is to add a method such as
```
def indexOptions: String = ""
```
then in each of the concrete test suite, implement this method, e.g. in
`MySQLIntegrationSuite`, implement it as
```
override def indexOptions: String = "KEY_BLOCK_SIZE=10"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
