huaxingao commented on a change in pull request #34673:
URL: https://github.com/apache/spark/pull/34673#discussion_r762663958
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -1073,6 +1076,81 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
+ /**
+ * Check if index exists in a table
+ */
+ def checkIfIndexExists(
+ conn: Connection,
+ sql: String,
+ options: JDBCOptions): Boolean = {
+ val statement = conn.createStatement
+ try {
+ statement.setQueryTimeout(options.queryTimeout)
+ val rs = statement.executeQuery(sql)
+ rs.next
+ } catch {
+ case _: Exception =>
+ logWarning("Cannot retrieved index info.")
+ false
+ } finally {
+ statement.close()
+ }
+ }
+
+ /**
+ * Process index properties and return tuple of indexType and list of the
other index properties.
+ */
+ def processIndexProperties(
+ properties: util.Map[String, String],
+ catalogName: String
+ ): (String, Array[String]) = {
+ var indexType = ""
+ val indexPropertyList: ArrayBuffer[String] = ArrayBuffer[String]()
+ val supportedIndexTypeList = getSupportedIndexTypeList(catalogName)
+
+ if (!properties.isEmpty) {
+ properties.asScala.foreach { case (k, v) =>
+ if (k.equals(SupportsIndex.PROP_TYPE)) {
+ if (containsIndexTypeIgnoreCase(supportedIndexTypeList, v)) {
+ indexType = s"USING $v"
+ } else {
+ throw new UnsupportedOperationException(s"Index Type $v is not
supported." +
+ s" The supported Index Types are:
${supportedIndexTypeList.mkString(" AND ")}")
+ }
+ } else {
+ indexPropertyList.append(convertPropertyPairToString(catalogName, k,
v))
+ }
+ }
+ }
+ (indexType, indexPropertyList.toArray)
+ }
+
+ def containsIndexTypeIgnoreCase(supportedIndexTypeList: Array[String],
value: String): Boolean = {
+ if (supportedIndexTypeList.isEmpty) {
+ throw new UnsupportedOperationException(s"None of index type is
supported.")
+ }
+ for (indexType <- supportedIndexTypeList) {
+ if (value.equalsIgnoreCase(indexType)) return true
+ }
+ false
+ }
+
+ def getSupportedIndexTypeList(catalogName: String): Array[String] = {
+ catalogName match {
+ case "mysql" => Array("BTREE", "HASH")
+ case "postgresql" => Array("BTREE", "HASH", "BRIN")
+ case _ => Array.empty
+ }
+ }
+
+ def convertPropertyPairToString(catalogName: String, key: String, value:
String): String = {
+ catalogName match {
+ case "mysql" => s"$key $value"
+ case "postgresql" => s"$key = $value"
+ case _ => ""
+ }
+ }
Review comment:
I think we don't need this method for now. Seems to me that databases
always allow this `=` in between of key and value. I didn't verify this syntax
in all the databases, but I checked MySQL, it takes `=` as optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
