pan3793 opened a new pull request #34831:
URL: https://github.com/apache/spark/pull/34831


   ### What changes were proposed in this pull request?
   
   Simplify code of fetchBlocks w/o retry
   
   ### Why are the changes needed?
   
   Simplify code.
   
   The original code added in [SPARK-4188], the `RetryingBlockTransferor` 
should be stable.
   
   #33340 renames `RetryingBlockFetcher` to `RetryingBlockTransferor`, the 
comments still calls it as `Fetcher`, it's a little misleading.
   
   ```
   if (maxRetries > 0) {
     // Note this Fetcher will correctly handle maxRetries == 0; we avoid it 
just in case there's
     // a bug in this code. We should remove the if statement once we're sure 
of the stability.
     new RetryingBlockTransferor(transportConf, blockFetchStarter, blockIds, 
listener).start()
   } else {
     blockFetchStarter.createAndStart(blockIds, listener)
   }
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   
   Existing UTs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to