mridulm commented on a change in pull request #34834:
URL: https://github.com/apache/spark/pull/34834#discussion_r766154512
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -954,7 +954,7 @@ private[spark] class TaskSetManager(
taskSetExcludelistHelperOpt.foreach(_.updateExcludedForFailedTask(
info.host, info.executorId, index, failureReason))
numFailures(index) += 1
- if (numFailures(index) >= maxTaskFailures) {
+ if (numFailures(index) >= maxTaskFailures && !successful(index)) {
Review comment:
~~Thoughts on moving this check to the outside `if` condition ?~~
~~Effectively treating a speculative task failure as
`countTowardsTaskFailures` = `false`~~
Thinking more, I am not very convinced this is the right change though.
+CC @Ngone51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
