itholic opened a new pull request #34931:
URL: https://github.com/apache/spark/pull/34931


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the 
guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   
   This PR proposes to support string and timestamp type columns for 
`(Series|DataFrame).describe()` API.
   
   Now `(Series|DataFrame).describe()` API only supports the numeric type 
column, so we should support other types.
   
   The initial issue is reported from Koalas user in legacy Koalas repo 
(https://github.com/databricks/koalas/issues/1888).
   
   
   ### Why are the changes needed?
   
   We should match the latest pandas' behavior as much as possible.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Users can apply the `(Series|DataFrame).describe()` API to the string and 
timestamp type columns which is unavailable before this fix.
   
   **Before**
   ```python
   >>> df = ps.DataFrame({'a': ["a", "b", "c"]})
   >>> df.describe()
   Traceback (most recent call last):
   ...
   ValueError: Cannot describe a DataFrame without columns
   ```
   
   **After**
   ```python
   >>> df = ps.DataFrame({'a': ["a", "b", "c"]})
   >>> df.describe()
           a
   count   3
   unique  3
   top     a
   freq    1
   ```
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions 
for the consistent environment, and the instructions could accord to: 
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   Added unittests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to