cloud-fan commented on a change in pull request #34826:
URL: https://github.com/apache/spark/pull/34826#discussion_r771126434
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
##########
@@ -529,4 +533,13 @@ object AggUtils {
case None => partialAggregate
}
}
+
+ /**
+ * Returns whether a sort aggregate should be force applied.
+ * The config key is hard-coded because it's testing only and should not be
exposed.
+ */
+ private def forceApplySortAggregate(conf: SQLConf): Boolean = {
+ Utils.isTesting &&
+ conf.getConfString("spark.sql.aggregate.forceApplySortAggregate",
"false") == "true"
Review comment:
I'd use `spark.sql.test.forceApplySortAggregate` to make the intention
clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
