sathiyapk commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r772740149
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -249,9 +249,9 @@ case class Cbrt(child: Expression) extends
UnaryMathExpression(math.cbrt, "CBRT"
""",
since = "1.4.0",
group = "math_funcs")
-case class Ceil(child: Expression) extends UnaryMathExpression(math.ceil,
"CEIL") {
+ case class Ceil(child: Expression) extends UnaryMathExpression(math.ceil,
"CEIL") {
override def dataType: DataType = child.dataType match {
Review comment:
@cloud-fan I think we can do something like this, what do you think ?
```
object Ceil {
def apply(child: Expression, scale: Expression): Expression = {
val scaleV = scale.eval(EmptyRow)
if (scaleV == null) return null
(child.dataType, scaleV.asInstanceOf[Int]) match {
case (_, 0) => Ceil(child)
case (_, x) if x < 0 => RoundCeil(Cast(child, LongType), scale)
case (_: IntegralType | ShortType, _) => RoundCeil(Cast(child,
LongType), scale)
case (_ : FloatType, _) => RoundCeil(Cast(child, DoubleType), scale)
case _ => RoundCeil(child, scale)
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
