Yikun commented on a change in pull request #34993:
URL: https://github.com/apache/spark/pull/34993#discussion_r774325742
##########
File path: python/pyspark/testing/utils.py
##########
@@ -22,6 +22,7 @@
import unittest
from time import time, sleep
+from pyspark.find_spark_home import _find_spark_home
from pyspark import SparkContext, SparkConf
Review comment:
I'm okay with this change, but I'm not sure why we need this change?
Actually, I deliberately put this addtion to the front 😂, because [1]:
`imports should be sorted lexicographically`. And flake8 also has a plugin
`import-order-style` (not enable in Spark) helps to check it.
`pysparkfind_spark_home_find_spark_home` should before
`pysparkSparkContextSparkConf`.
[1]
https://google.github.io/styleguide/pyguide.html?showone=Imports_formatting#313-imports-formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
