HyukjinKwon commented on a change in pull request #34993:
URL: https://github.com/apache/spark/pull/34993#discussion_r774333683



##########
File path: python/pyspark/testing/utils.py
##########
@@ -22,6 +22,7 @@
 import unittest
 from time import time, sleep
 
+from pyspark.find_spark_home import _find_spark_home
 from pyspark import SparkContext, SparkConf

Review comment:
       Actually it says:
   
   > imports should be sorted lexicographically, ignoring case, according to 
each module’s full package path (the `path` in `from path import ...`)
   
   Since `pyspark.` is after `pyspark` , I think placing `from pyspark import 
SparkContext, SparkConf` up seems correct :-). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to