srowen commented on a change in pull request #35017:
URL: https://github.com/apache/spark/pull/35017#discussion_r775957079
##########
File path: core/src/main/java/org/apache/spark/util/collection/TimSort.java
##########
@@ -120,8 +120,9 @@ public void sort(Buffer a, int lo, int hi, Comparator<?
super K> c) {
assert c != null;
int nRemaining = hi - lo;
- if (nRemaining < 2)
+ if (nRemaining < 2) {
Review comment:
I think we didn't change this file as it's copied as-is from another
source. Is there a way to just disable style checks? we could change the file
as I doubt we'll ever need to port updates, but who knows
##########
File path: sql/hive/src/test/java/org/apache/spark/sql/hive/test/Complex.java
##########
@@ -40,15 +40,29 @@
*/
@SuppressWarnings("all")
-public class Complex implements org.apache.thrift.TBase<Complex,
Complex._Fields>, java.io.Serializable, Cloneable {
- private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new
org.apache.thrift.protocol.TStruct("Complex");
-
- private static final org.apache.thrift.protocol.TField AINT_FIELD_DESC = new
org.apache.thrift.protocol.TField("aint", org.apache.thrift.protocol.TType.I32,
(short)1);
- private static final org.apache.thrift.protocol.TField A_STRING_FIELD_DESC =
new org.apache.thrift.protocol.TField("aString",
org.apache.thrift.protocol.TType.STRING, (short)2);
- private static final org.apache.thrift.protocol.TField LINT_FIELD_DESC = new
org.apache.thrift.protocol.TField("lint",
org.apache.thrift.protocol.TType.LIST, (short)3);
- private static final org.apache.thrift.protocol.TField L_STRING_FIELD_DESC =
new org.apache.thrift.protocol.TField("lString",
org.apache.thrift.protocol.TType.LIST, (short)4);
- private static final org.apache.thrift.protocol.TField
LINT_STRING_FIELD_DESC = new org.apache.thrift.protocol.TField("lintString",
org.apache.thrift.protocol.TType.LIST, (short)5);
- private static final org.apache.thrift.protocol.TField
M_STRING_STRING_FIELD_DESC = new
org.apache.thrift.protocol.TField("mStringString",
org.apache.thrift.protocol.TType.MAP, (short)6);
+public class Complex implements org.apache.thrift.TBase<Complex,
Complex._Fields>,
Review comment:
Same deal, this is copied from Hive, so maybe easier to leave it and
disable checkstyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
