Shockang commented on a change in pull request #35017:
URL: https://github.com/apache/spark/pull/35017#discussion_r776339299
##########
File path: core/src/main/java/org/apache/spark/util/collection/TimSort.java
##########
@@ -120,8 +120,9 @@ public void sort(Buffer a, int lo, int hi, Comparator<?
super K> c) {
assert c != null;
int nRemaining = hi - lo;
- if (nRemaining < 2)
+ if (nRemaining < 2) {
Review comment:
> I think we didn't change this file as it's copied as-is from another
source. Is there a way to just disable style checks? we could change the file
as I doubt we'll ever need to port updates, but who knows
The build errors are all from the java file, the file: scalastyle-config.xml
should not work. Do you know which file about java checkstyle works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
