AngersZhuuuu commented on a change in pull request #35059:
URL: https://github.com/apache/spark/pull/35059#discussion_r776370202



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/util/ExecutionListenerManagerSuite.scala
##########
@@ -69,3 +86,23 @@ private object CountingQueryExecutionListener {
   val INSTANCE_COUNT = new AtomicInteger()
 
 }
+
+private class SQLConfQueryExecutionListener(sqlConf: SQLConf) extends 
QueryExecutionListener {

Review comment:
       > Can we delay the creation of `QueryExecutionListener` to after the 
session is built?
   
   If so, we need to remove this parameter from SessionState, and make it as 
lazy. it's worth to do this? and it's hard to handle `createClone`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to