cloud-fan commented on a change in pull request #35052:
URL: https://github.com/apache/spark/pull/35052#discussion_r776565729
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownAggregates.java
##########
@@ -49,9 +51,10 @@
* Whether the datasource support complete aggregation push-down. Spark
could avoid partial-agg
* and final-agg when the aggregation operation can be pushed down to the
datasource completely.
*
+ * @param groupAttrs group by attributes of aggregation.
* @return true if the aggregation can be pushed down to datasource
completely, false otherwise.
*/
- default boolean supportCompletePushDown() { return false; }
+ default boolean supportCompletePushDown(String[] groupAttrs) { return false;
}
Review comment:
Why not just pass `Aggregation`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
