cloud-fan commented on a change in pull request #35052:
URL: https://github.com/apache/spark/pull/35052#discussion_r776714279
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCScanBuilder.scala
##########
@@ -72,8 +72,13 @@ case class JDBCScanBuilder(
private var pushedGroupByCols: Option[Array[String]] = None
- override def supportCompletePushDown: Boolean =
- jdbcOptions.numPartitions.map(_ == 1).getOrElse(true)
+ override def supportCompletePushDown(aggregation: Aggregation): Boolean = {
+ import
org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
+ lazy val fieldNames =
aggregation.groupByColumns().map(_.fieldNames.toSeq.quoted)
Review comment:
if we only support top-level columns, we should write code more
explicitly and return false if `fieldNames.length` > 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
