HyukjinKwon commented on a change in pull request #35071:
URL: https://github.com/apache/spark/pull/35071#discussion_r776898164
##########
File path: python/pyspark/sql/functions.py
##########
@@ -3707,7 +3709,9 @@ def arrays_overlap(a1: "ColumnOrName", a2:
"ColumnOrName") -> Column:
return Column(sc._jvm.functions.arrays_overlap(_to_java_column(a1),
_to_java_column(a2)))
-def slice(x: "ColumnOrName", start: Union[Column, int], length: Union[Column,
int]) -> Column:
+def slice(
+ x: "ColumnOrName", start: Union["ColumnOrName", int], length:
Union["ColumnOrName", int]
+) -> Column:
Review comment:
Since we're here, let's also update `Parameters` in docstring.
Especially we would have to document `start` and `length` to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
