itholic commented on a change in pull request #35071:
URL: https://github.com/apache/spark/pull/35071#discussion_r777851483
##########
File path: python/pyspark/sql/functions.py
##########
@@ -3102,24 +3121,36 @@ def instr(str: "ColumnOrName", substr: str) -> Column:
def overlay(
src: "ColumnOrName",
replace: "ColumnOrName",
- pos: Union[Column, int],
- len: Union[Column, int] = -1,
+ pos: Union["ColumnOrName", int],
+ len: Union["ColumnOrName", int] = -1,
Review comment:
ditto ?
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1715,13 +1715,18 @@ def greatest(*cols: "ColumnOrName") -> Column:
return Column(sc._jvm.functions.greatest(_to_seq(sc, cols,
_to_java_column)))
-def least(*cols: Column) -> Column:
+def least(*cols: "ColumnOrName") -> Column:
Review comment:
Maybe we also need to add the tests for this when the `*cols` is string ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
