aa1371 commented on a change in pull request #35083:
URL: https://github.com/apache/spark/pull/35083#discussion_r777097272
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -7648,52 +7654,6 @@ def to_list(os: Optional[Union[Name, List[Name]]]) ->
List[Label]:
else:
return [o if is_name_like_tuple(o) else (o,) for o in os]
- if isinstance(right, ps.Series):
Review comment:
Sure I can do this. FYI, unfortunately, as part of this refactor
implementation a large chunk of code was required to be indented one level,
which will still cause a large diff block, even though the changes are fairly
minimal.
How would you like me to structure the PRs? Would you rather:
(1) create a isolated code repositioning branch that will be merged to
master in one PR, and then a second join-feature update branch that will be
separately merged to master in a second PR?
Or (2) create a code repositioning branch, with a PR to master, and then
another join-feature update branch with a PR to the code repositioning branch.
The join feature branch will get merged into the other branch first, then that
branch to master.
I think (2) makes more sense, since if we don't agree on the implementation
of the join feature, then the code repositioning will just be unnecessarily
merged in noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
