HyukjinKwon commented on a change in pull request #35083:
URL: https://github.com/apache/spark/pull/35083#discussion_r777151289
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -7648,52 +7654,6 @@ def to_list(os: Optional[Union[Name, List[Name]]]) ->
List[Label]:
else:
return [o if is_name_like_tuple(o) else (o,) for o in os]
- if isinstance(right, ps.Series):
Review comment:
Actually, I would prefer to create an isolated PR that refactors this
into, for example, a separate private function or nested function as an example.
I think it's fine even without merging the join feature - this logic you are
moving seems better to be separate and factored out in any event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
