HyukjinKwon commented on a change in pull request #35084:
URL: https://github.com/apache/spark/pull/35084#discussion_r777266860
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala
##########
@@ -810,4 +810,15 @@ class TreeNodeSuite extends SparkFunSuite with SQLHelper {
fail("TreeNode.nodeName should not throw malformed class name error")
}
}
+
+ object Spark37800 {
+ case class TestNode(set: Set[String]) extends LogicalPlan with LeafNode {
Review comment:
Yeah, I know some projects use this way (adding issue ticket as the name
of class/objects) but it's not quite usual in Apache Spark codebase up to my
best knowledge.
We can even place this class as a nested class within `test("SPARK-37800:...
")` - I think that would address your points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
