HyukjinKwon commented on a change in pull request #35084:
URL: https://github.com/apache/spark/pull/35084#discussion_r777266697
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -807,7 +807,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product with Tre
truncatedString(seq.map(formatArg(_, maxFields)), "[", ", ", "]",
maxFields) :: Nil
case set: Set[_] =>
// Sort elements for deterministic behaviours
- val sortedSeq = set.toSeq.map(formatArg(_, maxFields).sorted)
+ val sortedSeq = set.toSeq.map(formatArg(_, maxFields)).sorted
Review comment:
I would prefer to just move `.sorted` (**Before**) instead of adding
some more changes but I am fine with **After** version if we're 100% sure
input/output are same as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
