cloud-fan commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r777975136
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -279,6 +280,49 @@ case class Ceil(child: Expression) extends
UnaryMathExpression(math.ceil, "CEIL"
override protected def withNewChildInternal(newChild: Expression): Ceil =
copy(child = newChild)
}
+object Ceil {
+ def apply(child: Expression, scale: Expression): Expression = {
+ val scaleV = scale.eval(EmptyRow)
+ if (scaleV == null) throw new AnalysisException("Scale parameter can not
be null")
+
+ scaleV.asInstanceOf[Int] match {
+ case 0 => Ceil(child)
+ case x if x < 0 => RoundCeil(Cast(child, LongType), scale)
+ case _ => RoundCeil(child, scale)
+ }
+ }
+}
+
+@ExpressionDescription(
+ usage = "_FUNC_(expr) - Returns the smallest integer not smaller than
`expr`.",
+ examples = """
+ Examples:
+ > SELECT _FUNC_(-0.1);
+ 0
+ > SELECT _FUNC_(5);
+ 5
+ > SELECT _FUNC_(3.1411, 3);
+ 3.142
+ """,
+ since = "3.3.0",
+ group = "math_funcs")
Review comment:
We can remove the doc string in `case class Ceil` now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
