cloud-fan commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r778071488
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -321,19 +322,29 @@ class MathExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkConsistencyBetweenInterpretedAndCodegen(Cbrt, DoubleType)
}
- def checkDataTypeAndCast(expression: UnaryMathExpression): Expression = {
+ def checkDataTypeAndCast(expression: Expression): Expression = expression
match {
+ case e: UnaryMathExpression => checkDataTypeAndCastUnaryMathExpression(e)
+ case e: RoundBase => checkDataTypeAndCastRoundBase(e)
+ }
+
+ def checkDataTypeAndCastUnaryMathExpression(expression:
UnaryMathExpression): Expression = {
val expNew = implicitCast(expression.child,
expression.inputTypes(0)).getOrElse(expression)
expression.withNewChildren(Seq(expNew))
}
+ def checkDataTypeAndCastRoundBase(expression: RoundBase): Expression = {
+ val expNewLeft = implicitCast(expression.left,
expression.inputTypes(0)).getOrElse(expression)
+ expression.withNewChildren(Seq(expNewLeft, expression.right))
+ }
+
test("ceil") {
- testUnary(Ceil, (d: Double) => math.ceil(d).toLong)
- checkConsistencyBetweenInterpretedAndCodegen(Ceil, DoubleType)
+ testUnary(Ceil.apply, (d: Double) => math.ceil(d).toLong)
+// checkConsistencyBetweenInterpretedAndCodegen(Ceil, DoubleType)
Review comment:
`testUnary(Ceil(_), ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
