cloud-fan commented on a change in pull request #35113:
URL: https://github.com/apache/spark/pull/35113#discussion_r779322478
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/CreateNamespaceSuite.scala
##########
@@ -25,5 +25,7 @@ import org.apache.spark.sql.execution.command.v1
*/
class CreateNamespaceSuite extends v1.CreateNamespaceSuiteBase with
CommandSuiteBase {
override def commandVersion: String =
super[CreateNamespaceSuiteBase].commandVersion
- override def alreadyExistErrorMessage: String = s"$notFoundMsgPrefix
$namespace already exists"
+ override def alreadyExistErrorMessage: String =
+ s"$notFoundMsgPrefix $namespaceMessage already exists"
+ private def namespaceMessage: String = if (runningV1Command) s"$namespace"
else s"'$namespace'"
Review comment:
is there a way to unify it? e.g. we can try-catch the hive error and
rethrow it with a new message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
