imback82 commented on a change in pull request #35113:
URL: https://github.com/apache/spark/pull/35113#discussion_r780418849
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -189,8 +189,15 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
override def createDatabase(
dbDefinition: CatalogDatabase,
- ignoreIfExists: Boolean): Unit = withClient {
- client.createDatabase(dbDefinition, ignoreIfExists)
+ ignoreIfExists: Boolean): Unit = {
+ try {
+ withClient {
+ client.createDatabase(dbDefinition, ignoreIfExists)
+ }
+ } catch {
+ case e: AnalysisException if e.message.contains("already exists") =>
+ throw new DatabaseAlreadyExistsException(dbDefinition.name)
Review comment:
Two concerns if we move the logic to `withClient`:
1. How can we guarantee
`org.apache.hadoop.hive.metastore.api.AlreadyExistsException` is thrown by
`createDatabase` but not for other calls like `createTable`?
2. Since db name is not available, we need to parse out the db name from the
message.
Are you OK with these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
