cloud-fan commented on a change in pull request #35113:
URL: https://github.com/apache/spark/pull/35113#discussion_r780993420
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -189,8 +204,17 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
override def createDatabase(
dbDefinition: CatalogDatabase,
- ignoreIfExists: Boolean): Unit = withClient {
+ ignoreIfExists: Boolean): Unit = withClientWrappingException {
client.createDatabase(dbDefinition, ignoreIfExists)
+ } { exception =>
+ if (exception.getClass.getName.equals(
+ "org.apache.hadoop.hive.metastore.api.AlreadyExistsException")
+ && exception.getMessage.contains(
+ s"Database ${dbDefinition.name} already exists")) {
+ Some(new DatabaseAlreadyExistsException(dbDefinition.name))
Review comment:
Can we test it in the `VersionsSuite`, by updating the existing
`$version: createDatabase` test? We need to make sure this wrap exception logic
works for all hive versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
