cloud-fan commented on a change in pull request #35060: URL: https://github.com/apache/spark/pull/35060#discussion_r781169711
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import java.util.Locale + +import org.apache.spark.sql.catalyst.analysis.TypeCheckResult +import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, CodeGenerator, ExprCode} +import org.apache.spark.sql.catalyst.expressions.codegen.Block.BlockHelper +import org.apache.spark.sql.catalyst.util.NumberUtils.NumberFormatBuilder +import org.apache.spark.sql.types.{DataType, DecimalType, StringType} +import org.apache.spark.unsafe.types.UTF8String + +/** + * A function that converts string to numeric. + */ +@ExpressionDescription( + usage = """ + _FUNC_(strExpr, formatExpr) - Convert `strExpr` to a number based on the `formatExpr`. + The format can consist of the following characters: + '0' or '9': digit position + '.' or 'D': decimal point (only allowed once) + ',' or 'G': group (thousands) separator + '-' or 'S': sign anchored to number + '$': returns value with a leading dollar sign + """, + examples = """ + Examples: + > SELECT _FUNC_('454', '999'); + 454 + > SELECT _FUNC_('454.00', '000D00'); + 454.00 + > SELECT _FUNC_('12,454', '99G999'); + 12454 + > SELECT _FUNC_('$78.12', '$99.99'); + 78.12 + > SELECT _FUNC_('12,454.8-', '99G999D9S'); + -12454.8 + """, + since = "3.3.0", + group = "string_funcs") +case class ToNumber(left: Expression, right: Expression) + extends BinaryExpression with ImplicitCastInputTypes with NullIntolerant { + + private lazy val numberFormat = right.eval().toString.toUpperCase(Locale.ROOT) + private lazy val numberFormatBuilder = new NumberFormatBuilder(numberFormat) + private lazy val (precision, scale) = numberFormatBuilder.parsePrecisionAndScale() + + override def dataType: DataType = DecimalType(precision, scale) + + override def inputTypes: Seq[DataType] = Seq(StringType, StringType) + + override def checkInputDataTypes(): TypeCheckResult = { + val inputTypeCheck = super.checkInputDataTypes() + if (inputTypeCheck.isSuccess) { + if (right.foldable) { + numberFormatBuilder.check() + } else { + TypeCheckResult.TypeCheckFailure(s"Format expression must be foldable, but got $right") + } + } else { + inputTypeCheck + } + } + + override def prettyName: String = "to_number" + + override def nullSafeEval(string: Any, format: Any): Any = { + val input = string.asInstanceOf[UTF8String] + numberFormatBuilder.parse(input) + } + + override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = { + val builder = + ctx.addReferenceObj("builder", numberFormatBuilder, classOf[NumberFormatBuilder].getName) + val eval = left.genCode(ctx) + ev.copy(code = code""" Review comment: nit: use multi-line string. ``` code""" |... """.stripMargin ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
