cloud-fan commented on a change in pull request #35060:
URL: https://github.com/apache/spark/pull/35060#discussion_r781186203
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberUtils.scala
##########
@@ -136,21 +164,32 @@ object NumberUtils {
inputSplits(1).filterNot(isSign).length > scale) {
throw QueryExecutionErrors.invalidNumberFormatError(numberFormat)
}
+
+ val transformedFormat = transform(normalizedNumberFormat)
+ val numberFormatInstance = NumberFormat.getNumberInstance(Locale.ROOT)
+ assert(numberFormatInstance.isInstanceOf[DecimalFormat])
Review comment:
why can't we just do `new DecimalFormat()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
