LuciferYang commented on pull request #35154: URL: https://github.com/apache/spark/pull/35154#issuecomment-1009989871
> Are they all meaningful simplifications beyond just avoiding an if, and instanceOf? I'd fix more if you can yes I have finished the other changes, but I haven't submitted it yet. All of them are use `case match` instead of type check, there seems to be no more code simplification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
